fix(package): Allow .json extension on annotations file (issue #836)#886
Merged
bmuenzenmeyer merged 1 commit intopattern-lab:devfrom Jul 13, 2018
Merged
Conversation
Member
Author
|
I realized I may have misunderstood the file naming convention - when do I use |
Member
|
@engelfrost thank you so much for the contribution! I will take a look at it ASAP.
camelCase is my newer convention. when I started writing the app I was using underscores but have never went through and changed them all. Probably a good refactor task at some point |
Member
|
@engelfrost Thank you so much my friend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #836
Summary of changes:
Read annotations.json if it exists.
Else read annotations.js.
Not sure if being able to read the old file is a necessary convenience. If not, that part of the code (the else statement) can easily be removed.